-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pipeline #164
Fix pipeline #164
Conversation
@cmutel apparently, bw2data is currently broken when installed from pip due to outdated dependencies. Could you update packages on pypi to match the status of conda? |
@tngTUDOR @michaelweinold anything you can do? |
This is likely caused by a change in the |
@michaelweinold note that the tests work when installing with conda. I believe the packages on pypi are outdated |
@BenPortner, which packaged do you think are missing in PyPi? From what I can see, the
but still lets those tests using The Conda tests use
The changelog of pytest is a little confusing as to with which pytest version exactly the I won't have time to check what was intended in the |
@BenPortner , can you please confirm that this is related to the This issue talks about the azure pipelines, but overall brightway-lca org is moving to using github only with for CI/CD and one specific task is to move to using the cookiecutter brightwaylib template for all operations. So we would need to fix this issue, not only for the uploading to pypi, but also by using the new CI/CD workflows (i.e.: move away from azure). |
use --pre for pip installations to include package dev versions
two tests try to assert that no warnings are raised. the way to do this changed from pytest 7.x to 8.x. new way is copied from https://docs.pytest.org/en/8.0.x/how-to/capture-warnings.html
I fixed it. No need to intervene on your side anymore. Answers to your comments below.
You were partly right. Although the pipeline pulled the main branch, I had accidentally deleted the
Not sure how to provide a more reproducible example than a pipeline 😅 Pull the code, change something, push and open a PR, see the pipeline fail. Not sure how else to test this...
Not sure why we need this additional layer of complexity. Either way I am strong in favor of fixing the existing pipelines before switching to a more convoluted approach. Otherwise, how are you going to see where things broke?
This was part of the problem and I fixed it. The other part was caused by pip not installing dev packages because I accidentally deleted the |
No description provided.