Use python module dynamic imports for getting app modules #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using get_app requires apps to have a models module even though this is not required anymore Fixes #6
| dirname = os.path.dirname(module.__file__) | ||
| ret.extend(get_coverage_files_in_directory(dirname, ignore_dirs, ignore_files)) | ||
| if app_label in settings.INSTALLED_APPS: | ||
| module = __import__(app_label, fromlist=['']) |
There was a problem hiding this comment.
https://docs.python.org/2/library/functions.html#__import__ recommends against using __import__ in everyday Python programming in favour of importlib.import_module().
If you do need to use it (not sure if importlib.import_module() is available in Python 2.6) then it might make sense to pass globals(), locals(), [], -1) to it like the examples in the above link do.
There was a problem hiding this comment.
I've updated the __import__call to include globals() and locals(). You will probably see that I'm not using the [] in the call. That's because in case of dotted imports, using [] instead of [''] returns the base module.
PS. Not using importlib since it's py2.7 and over
georgebrightinteractive
added a commit
that referenced
this pull request
Apr 21, 2015
Use python module dynamic imports for getting app modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using get_app requires apps to have a models module even though this is not required anymore
Fixes #6