Skip to content

Conversation

@leogdion
Copy link
Member

@leogdion leogdion commented Oct 3, 2021

No description provided.

@leogdion leogdion marked this pull request as ready for review October 3, 2021 20:38
@codecov
Copy link

codecov bot commented Oct 3, 2021

Codecov Report

Merging #101 (3820274) into main (13efde1) will increase coverage by 0.52%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   34.76%   35.28%   +0.52%     
==========================================
  Files          46       46              
  Lines         676      666      -10     
==========================================
  Hits          235      235              
+ Misses        441      431      -10     
Flag Coverage Δ
5.2.4 35.18% <44.44%> (+0.52%) ⬆️
5.3.1 ?
5.3.3 35.28% <44.44%> (?)
5.4.1 35.28% <44.44%> (?)
5.5 33.48% <22.22%> (?)
bionic 35.28% <44.44%> (+0.52%) ⬆️
focal 35.28% <44.44%> (+0.52%) ⬆️
github 35.28% <44.44%> (+0.52%) ⬆️
macOS 35.28% <44.44%> (+0.52%) ⬆️
macos-10.15 35.28% <44.44%> (+0.52%) ⬆️
macos-11 35.28% <44.44%> (?)
macos-11.0 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/MistKit/Controllers/ResultSink.swift 0.00% <0.00%> (ø)
...Kit/Requests/RecordsLookup/LookupRecordQuery.swift 0.00% <ø> (ø)
...Kit/Requests/RecordsModify/ModifyRecordQuery.swift 0.00% <ø> (ø)
...stKit/Requests/RecordsQuery/FetchRecordQuery.swift 100.00% <ø> (ø)
.../MistKit/Authentication/MKStaticTokenManager.swift 100.00% <100.00%> (ø)
...ources/MistKit/Authentication/MKTokenManager.swift 86.66% <100.00%> (ø)
Sources/MistKit/Protocols/MKRequest.swift 100.00% <100.00%> (ø)
Sources/MistKit/URLNetworking/MKURLBuilder.swift 37.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13efde1...3820274. Read the comment docs.

@leogdion leogdion merged commit 5440403 into main Oct 3, 2021
@leogdion leogdion deleted the release/0.2.4 branch May 25, 2023 11:43
leogdion added a commit that referenced this pull request Aug 29, 2025
* removing print statement from DEBUG

* updating package

* fixing macos github action

* fixing dataResult

* fixing swift test coverage

* fixing SwiftNIO issue
leogdion added a commit that referenced this pull request Sep 27, 2025
* removing print statement from DEBUG

* updating package

* fixing macos github action

* fixing dataResult

* fixing swift test coverage

* fixing SwiftNIO issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants