fix(brig): set a default sidecar #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacongobbler
approved these changes
Aug 13, 2018
In the course of debugging this, I noticed a case in the worker where the error data was getting lost. Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
|
Hrm... I cannot reproduce that error. I'll have to see if it's a flake |
technosophos
force-pushed
the
bug/590-brig-vcs-sidecar
branch
from
7a7a84e to
3ff82e7
Compare
|
Alright, it was an issue with needing to rebase. Seems to be fixed at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of debugging this, I noticed a case in the worker where the error data was getting lost.
Signed-off-by: Matt Butcher matt.butcher@microsoft.com