Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(javascript_advanced): create an advanced JS guide #562

Merged
merged 1 commit into from
Jul 27, 2018
Merged

docs(javascript_advanced): create an advanced JS guide #562

merged 1 commit into from
Jul 27, 2018

Conversation

technosophos
Copy link
Contributor

This provides a place for advanced JS examples and ideas.

See #480

@technosophos technosophos self-assigned this Jul 18, 2018
@technosophos
Copy link
Contributor Author

technosophos commented Jul 18, 2018 •
edited
Loading

Other ideas for things to put here?

I was thinking:

  • async/await
  • move content on brigade.json and building custom workers to this section

@technosophos technosophos force-pushed the docs/advanced-js-guide branch 2 times, most recently from 0f12e28 to 23dd9ca Compare July 26, 2018 23:06
@technosophos technosophos changed the title WIP docs(javascript_advanced): create an advanced JS guide docs(javascript_advanced): create an advanced JS guide Jul 26, 2018
@technosophos
Copy link
Contributor Author

This is ready for review

@bacongobbler
Copy link
Contributor

bacongobbler commented Jul 26, 2018 •
edited
Loading

timely! I'll have a look over this tomorrow w/ morning coffee ☕️

@technosophos
docs(javascript_advanced): create an advanced JS guide
29eaf71 
This provides a place for advanced JS examples and ideas.

See brigadecore#480
@technosophos technosophos force-pushed the docs/advanced-js-guide branch from 23dd9ca to 29eaf71 Compare July 26, 2018 23:33
bacongobbler
bacongobbler approved these changes Jul 27, 2018
View reviewed changes
Copy link
Contributor

@bacongobbler bacongobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Love the OOP example using the MyJob class. That could be very useful.

This gives me an idea: eventually we should brainstorm some good ideas for external libraries that can be added to brigade.json. 👍

@technosophos technosophos merged commit e3ad766 into brigadecore:master Jul 27, 2018
@technosophos technosophos deleted the docs/advanced-js-guide branch July 27, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacongobbler bacongobbler bacongobbler approved these changes

Assignees

@technosophos technosophos

@bacongobbler bacongobbler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@technosophos @bacongobbler