Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade go-tools to v0.9.0 #1897

Merged
merged 2 commits into from
Mar 30, 2022
Merged

upgrade go-tools to v0.9.0 #1897

merged 2 commits into from
Mar 30, 2022

Conversation

krancour
Copy link
Contributor

No description provided.

@krancour
upgrade go-tools to v0.9.0
b9c9f88 
Signed-off-by: Kent Rancourt <kent.rancourt@microsoft.com>
@krancour krancour added this to the v2.4.0 milestone Mar 30, 2022
@krancour krancour requested a review from vdice March 30, 2022 20:51
@krancour krancour self-assigned this Mar 30, 2022
@netlify
Copy link

netlify bot commented Mar 30, 2022 •
edited
Loading

✅ Deploy Preview for brigade-docs ready!

Name Link
🔨 Latest commit 7f07946
🔍 Latest deploy log https://app.netlify.com/sites/brigade-docs/deploys/6244d03f65cfcb000860b94b
😎 Deploy Preview https://deploy-preview-1897--brigade-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

vdice
vdice reviewed Mar 30, 2022
View reviewed changes
Copy link
Contributor

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- we can remove the go get github.com/tcnksm/ghr from the applicable Make target(s) (and/or elswhere?), right?

@krancour
Copy link
Contributor Author

@vdice yes. I was planning on doing it in a follow up, but I'm equally happy to bundle it in this PR if you prefer.

@krancour
release: do not do just-in-time ghr install for publishing brig binaries
7f07946 
Signed-off-by: Kent Rancourt <kent.rancourt@microsoft.com>
@krancour
Copy link
Contributor Author

krancour commented Mar 30, 2022 •
edited
Loading

Added it in 7f07946.

@krancour krancour merged commit 5fbdb64 into brigadecore:main Mar 30, 2022
@krancour krancour deleted the upgrade-go-tools branch March 30, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdice vdice vdice approved these changes

Assignees

@krancour krancour

Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@krancour @vdice