Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved windows support #1718

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Conversation

krancour
Copy link
Contributor

@krancour krancour commented Nov 5, 2021

This corrects several overlooked aspects of our support for Windows-based jobs:

  1. When applicable, uses node selector to request scheduling on a Windows node.
  2. When applicable, uses a toleration to tolerate being scheduled on a Windows node.
  3. When applicable, uses Windows-based variant of git initializer component.
  4. Adds a Windows example

@krancour krancour self-assigned this Nov 5, 2021
@netlify
Copy link

netlify bot commented Nov 5, 2021

✔️ Deploy Preview for brigade-docs ready!

🔨 Explore the source changes: 442cfee

🔍 Inspect the deploy log: https://app.netlify.com/sites/brigade-docs/deploys/6185afad6d416b0007202100

😎 Browse the preview: https://deploy-preview-1718--brigade-docs.netlify.app

@krancour krancour force-pushed the improved-windows-support branch 2 times, most recently from abf035e to 0dd7d56 Compare November 5, 2021 18:57
Signed-off-by: Kent Rancourt <kent.rancourt@microsoft.com>
@krancour krancour force-pushed the improved-windows-support branch from 0dd7d56 to 442cfee Compare November 5, 2021 22:26
@krancour krancour marked this pull request as ready for review November 5, 2021 22:27
@krancour krancour added this to the 2.0.0-beta.4 milestone Nov 5, 2021
Copy link
Contributor

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krancour
Copy link
Contributor Author

krancour commented Nov 8, 2021

/brig run

@krancour krancour merged commit 3a5bf52 into brigadecore:v2 Nov 8, 2021
@krancour krancour deleted the improved-windows-support branch November 8, 2021 18:09
krancour added a commit that referenced this pull request Nov 30, 2021
Signed-off-by: Kent Rancourt <kent.rancourt@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants