Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do not publish edge images on merge to main #42

Merged
merged 1 commit into from
Feb 11, 2022
Merged

ci: do not publish edge images on merge to main #42

merged 1 commit into from
Feb 11, 2022

Conversation

krancour
Copy link
Contributor

For quite some time, we've published images tagged with a git sha and "edge" upon every merge to main -- the result being that we use up a lot of storage on DockerHub. Most of these images are never pulled/used, as they don't represent stable, officially released software. As I prepare for the possibility of moving off of DockerHub for various reasons, I'm becoming more conscious of not using up registry space so indiscriminately.

This PR stops us from publishing "edge" images after each merge.

Signed-off-by: Kent Rancourt <kent.rancourt@microsoft.com>
@krancour krancour added the chore A small task reviewable by non-maintainers label Feb 10, 2022
@krancour krancour added this to the v0.4.0 milestone Feb 10, 2022
@krancour krancour self-assigned this Feb 10, 2022
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #42 (71c735c) into main (b24aee8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   58.46%   58.46%           
=======================================
  Files           5        5           
  Lines         195      195           
=======================================
  Hits          114      114           
  Misses         78       78           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24aee8...71c735c. Read the comment docs.

@krancour
Copy link
Contributor Author

@vdice approved this here.

@krancour krancour merged commit adb1454 into brigadecore:main Feb 11, 2022
@krancour krancour deleted the no-pub-edge branch February 11, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A small task reviewable by non-maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant