Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ClusterIP as the default service type #32

Merged
merged 2 commits into from
Nov 16, 2021
Merged

use ClusterIP as the default service type #32

merged 2 commits into from
Nov 16, 2021

Conversation

krancour
Copy link
Contributor

@krancour krancour commented Nov 16, 2021

This leads to a smoother install experience because we can use --wait.

Signed-off-by: Kent Rancourt <kent.rancourt@microsoft.com>
@krancour krancour self-assigned this Nov 16, 2021
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #32 (f44db7b) into main (712b395) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   58.46%   58.46%           
=======================================
  Files           5        5           
  Lines         195      195           
=======================================
  Hits          114      114           
  Misses         78       78           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 712b395...f44db7b. Read the comment docs.

@krancour krancour merged commit e4984ef into brigadecore:main Nov 16, 2021
@krancour krancour deleted the service-type branch November 16, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants