This repository was archived by the owner on Jan 18, 2024. It is now read-only.
chore: angular cli as a dev dep #104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the schematic installs angular devkit in version 10 when added in a CLI project v12,
This brings an unneeded dependency, which throws warnings when using the builder since some changes have been done in v12, like:
"BuilderProgressSchema" schema is using the keyword "id" which its support is deprecated. Use "$id" for schema ID.
This commit updates the dependencies to v11, and moves them as peer deps, like most builder do.
|
Arf, the API is different in the devkit v11, so we need to update the builder code. Closing for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the schematic installs angular devkit in version 10 when added in a CLI project v12,
This brings an unneeded dependency, which throws warnings when using the builder since some changes have been done in v12, like:
This commit updates the dependencies to v11, and moves them as peer deps, like most builder do.