Improve localization helpers #842
Conversation
- Added support for relative translation keys (ex: `t('.foo')`).
- Added support for automatically marking translation keys ending with `_html` as `html_safe`.
- Renamed methods to `translate` and `localize` with aliases of `t` and `l`.
- Added tests
|
This looks really good @jclusso! I would like to avoid adding the dependency on Active Support here (since we're generally headed in the opposite direction). Looking at the code being called, it seems fairly self-contained: https://github.com/rails/rails/blob/main/activesupport/lib/active_support/html_safe_translation.rb If you're feeling particularly ambitious, I might ask you to write a greenfield take on this functionality—otherwise, I'm completely fine with vendoring this into its own module file somewhere and a commented link to the original code on GH. LMK what you think, I'm good with either option. TY 🙏🏻 |
|
Thanks @jaredcwhite! I'm not super familiar with how the whole string safety thing works and I wouldn't feel comfortable blindly ripping this out of Active Support. I feel it's also worth noting that Active Support is one of the top 10 most downloaded gems and it really seems like a poor use of my time to reinvent the wheel. I personally can't justify that since I have a limited amount of time I can put into OS projects and I much rather put it into something that moves the needle. I hope you can understand. It would be a shame if that was a deal breaker for this PR since I think a lot of people would find this useful. |
|
I'll go ahead and merge and rewrite that dependency. We're just not going to be relying on any new Active Support functionality going forward. Thanks for the PR. |
t('.foo'))._htmlashtml_safe.translateandlocalizewith aliases oftandl.This is a 🙋 feature or enhancement.
This is a 🔦 documentation change.
Closes #837