Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Netlify bundled configuration #839

Merged

Conversation

jclusso
Copy link
Contributor

@jclusso jclusso commented Feb 17, 2024

Summary

  • Add support for using netlify dev. This is important if you want to test redirects or use functions.
  • Removed Link headers. This was breaking stuff locally and Netlify doesn't have a way to apply headers conditionally without using scripts. Honestly, I'm not sure it's really that important anyway. I checked a bunch of sites including Google, Cloudflare, Netlify, Apple, Stripe, and more. None of them set these headers. This simplifies stuff to remove them.

This is a 🙋 feature or enhancement.

@jaredcwhite
Copy link
Member

I'm guessing you'd need to remove the references to the shell script in bridgetown-core/lib/bridgetown-core/configurations/netlify.rb as well?

- Add support for using `netlify dev`. This is important if you want to test redirects or use functions.
- Removed Link headers. This was breaking stuff locally and Netlify doesn't have a way to apply headers conditionally without using scripts. Honestly, I'm not sure it's really that important anyway. I checked a bunch of sites including Google, Cloudflare, Netlify, Apple, Stripe, and more. None of them set these headers. This simplifies stuff to remove them.
@jclusso jclusso force-pushed the improve_netlify_bundled_config branch from 1217c06 to ffd857e Compare February 17, 2024 16:40
@jclusso
Copy link
Contributor Author

jclusso commented Feb 17, 2024

I'm guessing you'd need to remove the references to the shell script in bridgetown-core/lib/bridgetown-core/configurations/netlify.rb as well?

Whoops, missed that. Should be fixed now.

@jaredcwhite jaredcwhite merged commit 10bfa89 into bridgetownrb:main Feb 22, 2024
0 of 4 checks passed
@jclusso jclusso deleted the improve_netlify_bundled_config branch February 26, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants