Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
This is a 🙋 feature or enhancement.
Summary
This pull request fixes, enhances and tests i18n liquid tags & filters.
Context
Localization
The newly introduced localization (#759) liquid filter & tag does not work, because
I18n.l
requires an argument that responds to#strftime
, which is not the case for String.This PR relies on
Liquid::Utils.to_date
to handle date strings.And localization filter & tag now support arguments and are fully tested.
Usage:
Note:
l
tag arguments are split by a space, so datetime must not contain a space character.Translation
Translation tag & filter now accept arguments too, and are fully tested.
Usage:
Note:
t
tag & filter arguments arekey:value
pairs separated by commas.