-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relocate all Bridgetown Roda logic to new bridgetown_server
plugin
#737
Conversation
- Also catch syntax errors in dev watchers
Your Render PR Server URL is https://bridgetown-api-pr-737.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cgkcb068h4931r1vlomg. |
Your Render PR Server URL is https://bridgetown-beta-pr-737.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cgkcb0m8h4931r1vlopg. |
@michaelherold I'm curious what your thoughts are on this PR! |
bridgetown_stack
pluginbridgetown_init
plugin
Can we just call the plugin |
@ayushn21 I believe I tried that and ran into some annoying namespace issues, but I'll see if I can come up with a workaround. I agree that would probably be ideal. |
bridgetown_init
pluginbridgetown_server
plugin
|
LGTM! |
I think that this will make testing easier without using integration tests, but haven't had the creative energy available to test it. Good idea, Jared! Once I am able, I will post an experience report on the new structure. |
This is an alternate take on the concepts brought forth by @michaelherold in #706
Rather than have
RodaApp
subclass from a Bridgetown-specific subclass ofRoda
, you can simply subclass fromRoda
like any standard Roda application, and then use thebridgetown_stack
* plugin to pull in all of Bridgetown's setup.This provides the added benefits of future improvements where some of the ways in which the stack plugin sets up the app could be further configurable as plugin options.
* Still thinking about the best name to call this. Also there's opportunity to consolidate some of the existing plugin(s) into this new one.
** Thinking of going with
unless there are any objections.bridgetown_init
*** Core team consensus was to go with
bridgetown_server
– thanks @KonnorRogers!