fix: load initializers.rb instead of require for working tests
#700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://bridgetown-beta-pr-700.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cf81va82i3mt56g2d3dg. |
|
Your Render PR Server URL is https://bridgetown-api-pr-700.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cf81vbg2i3mt56g2d3k0. |
ayushn21
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes the code which executes Bridgetown's Ruby configuration DSL so initializer files in
configare loaded vialoadrather thanrequireContext
In testing scenarios (such as plugin gems) when
run_initializers!may be called many times across a series of tests, the available initializers were blank after the first run. That's because the file to set up those initializers wasn't getting executed by Ruby. We need toloadrather thanrequirethose files.I'm pretty sure this isn't a breaking change, but we'll want to keep an eye on any odd behavior (possibly due to some mistake in attempting to run initializers more than once on the same site config)