Filter Bridgetown::Localizable#all_locales under the source's parent directory
#671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilvanbeinum
changed the title
Resource#all_locales under that resource's parent directoryBridgetown::Localizable#all_locales under that resource's parent directory
neilvanbeinum
changed the title
Bridgetown::Localizable#all_locales under that resource's parent directoryBridgetown::Localizable#all_locales under the source's parent directory
Otherwise, sources with the same slug but in another directory are included.
neilvanbeinum
force-pushed
the
all-locales-issue-660
branch
from
a50dc93
to
599c4d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
Summary
This is to avoid an issue where resources with the same slugs under different directories are included in the results.
Context
Closes #660