Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo: mergable => mergeable #635

Merged
merged 1 commit into from
Oct 14, 2022
Merged

typo: mergable => mergeable #635

merged 1 commit into from
Oct 14, 2022

Conversation

alexanderadam
Copy link
Contributor

This is a 🔦 tiny naming change.

Summary

I have the feeling that it's called mergeable but I'm not a native speaker so I might be wrong.

Context

@jaredcwhite
Copy link
Member

@alexanderadam Yeah, I think you're right! Can you add an alias_method so the typo version is still around and we don't introduce a breaking change?

@alexanderadam
Copy link
Contributor Author

@jaredcwhite I updated the PR

@jaredcwhite
Copy link
Member

Looks great! ✌️

@jaredcwhite jaredcwhite merged commit ce53dd8 into bridgetownrb:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants