Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bundled configuration for Vercel #483

Merged
merged 3 commits into from
Jan 20, 2022
Merged

feat: add bundled configuration for Vercel #483

merged 3 commits into from
Jan 20, 2022

Conversation

andrewmcodes
Copy link
Contributor

This is a 🙋 feature or enhancement.

Summary

Adds a bundled configuration for Vercel with correct security headers and content type for feeds.xml (if using the RSS plugin).

It also correctly assigns the Bridgetown URL to the VERCEL_URL in non-production environments. This means that if a VERCEL_URL is in the environment, whether production or running via Vercel's CLI locally, the absolute url's will adjust accordingly.

See example of it in use in the deploys on this PR

Context

I spoke about this with Jared. I think pre-1.0 we should make the deployment path to whatever service of your choosing as simple as possible without any need to dig into why something is behaving odd.

@andrewmcodes andrewmcodes marked this pull request as ready for review January 15, 2022 01:01
@jaredcwhite jaredcwhite merged commit 6c5c7f1 into bridgetownrb:main Jan 20, 2022
@jaredcwhite
Copy link
Member

Thanks @andrewmcodes!

@andrewmcodes andrewmcodes deleted the add-vercel-bundled-configuration branch January 20, 2022 16:29
@andrewmcodes
Copy link
Contributor Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants