fix: extensions infinite loading - #841
Merged
Merged
Conversation
|
|
solvedDev
changed the title
Joelant05
approved these changes
Jan 7, 2023
Merged
solvedDev
added a commit
that referenced
this pull request
Jan 7, 2023
## Features: ### Tree Editor Validation (#825) bridge. v2.6.0's tree editor now supports showing JSON schema validation errors. This should help our users identify problems earlier and brings the tree editor closer to our text editor.  - - - ### Launch Minecraft (#845) You can now launch Minecraft with bridge. by pressing "F5".  - - - ### About Window (#819) We have added a new about window to show the currently installed version of bridge. and link out to our Twitter, Discord and GitHub.  - - - ### New Error Window (#823) bridge. v2.6.0 ships with a new window for displaying errors. It now includes convenient buttons for directly reporting a bug and copying the error text  - - - ### Update Window (#834) Starting with bridge. v2.6.0, a prompt window will open upon starting the native app if an update is available.  - - - ### View bridge. Folder (#843) It is now easier to access the folder in which bridge. stores your projects on our native build.  - - - ### Better Discord RPC (#820) bridge. now displays the file type of the current file you are editing within your Discord status. ## Changes: - Added support for the latest Minecraft Preview (6ab52ab) - Removed unused first project logic (d9c37d7) - Solid windows now respect user themes (#837) - It is now possible to view com.mojang projects if no bridge. projects were created yet (#845) ## Fixes: - Fixed web app build (38b4b2e) - Fixed various issues connected to virtual files (#817) - Fixed mobile context menu overflowing available screen space (#822) - Fixed native app suggestion on mobile (#828; Thanks to @ThomasOrs) - Fixed remote alert color (f93f1a3) - Fixed JSON schema warning: Ignore "markdownDescription" (71fe4ff) - Disabled spellcheck on all input elements (947ef4f) - Fixed custom component scope (993fa80) - Fixed extensions infinitely loading (#841) - Fixed "Reveal In File Explorer" action for com.mojang projects (#841) - Fixed preprocessor scripts (bridge-core/editor-packages#32; Thanks to @Tschipp)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR properly handles JSON errors within the extension manifest (emit warning and abort further processing) instead of throwing an error that would subsequently cause infinite loading when opening the extension store.
Motivation
closes #840