Mdl 69863 311 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnicols
force-pushed
the
MDL-69863-311
branch
4 times, most recently
from
4b1939e to
c0fc2b6
Compare
…ome cases My configuration (validly) uses a symlink to put the moodledir into the document root, but tcpdf forcibly inserts the DOCUMENT_ROOT into the path if it is not already there, which breaks images in tcpdf.
We muts not generate HTML content manually via string concatenation. This patch modifies the block to use a mustache template instead, allowing themers to make any changes they desire. Images are copied into the block, instead of using the same variants in core as per coding style. This allows themers to use different icons if they prefer. The patch also removes the need for module-specific hacks (i.e. label), by using a CSS class with higher specificity to capture those places affected. Finally language strings are composed via get_string rather than string concatenation.
andrewnicols
force-pushed
the
MDL-69863-311
branch
from
c0fc2b6 to
95bb05f
Compare
We should try to avoid one component directly accessing DB tables in another component. This has a tendency to break things. This commit moves those DB calls to a static function on the brickfields manager which is called instead.
AJAX features should ideally not create their own functions to set/update user preferences but use the core_user_update_user_preferences web service. This commit removes the block_accessreview_update_toggle_preference external service in favour of the core_user_update_user_preferences service. It also bundles the call to this service in with the call to fetch the data when relevant. This reduces the number of ajax fetches when toggling.
andrewnicols
force-pushed
the
MDL-69863-311
branch
from
95bb05f to
a4c54ba
Compare
andrewnicols
force-pushed
the
MDL-69863-311
branch
2 times, most recently
from
3c9fdd5 to
1303651
Compare
andrewnicols
force-pushed
the
MDL-69863-311
branch
from
1303651 to
ccefb5f
Compare
andrewnicols
force-pushed
the
MDL-69863-311
branch
from
ccefb5f to
25973f5
Compare
learningtechnologyservices
pushed a commit
that referenced
this pull request
Nov 27, 2023
We encountered errors on the plugin check page while upgrading from version 3.11 to 4.3. The plugins marked with the status "To be deleted" have a null value for the $component property, which results in the following error message: "Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in lib/classes/component.php on line 1056." To avoid this error, we need to set an empty string as the default value for the $component property.
learningtechnologyservices
pushed a commit
that referenced
this pull request
Nov 27, 2023
We encountered errors on the plugin check page while upgrading from version 3.11 to 4.3. The plugins marked with the status "To be deleted" have a null value for the $component property, which results in the following error message: "Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in lib/classes/component.php on line 1056." To avoid this error, we need to set an empty string as the default value for the $component property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** PLEASE DO NOT OPEN PULL REQUESTS VIA GITHUB ***
The moodle.git repository at Github is just a mirror of the official repository. We do not accept pull requests at Github.
See CONTRIBUTING.txt guidelines for how to contribute patches for Moodle. Thank you.
--