feat: add isbn 10/13 fake generation support #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #367
Description
Adds support for ISBN 10/13 strings in
gofakeitlibrary. It's inspired from https://github.com/joke2k/faker/blob/master/faker/providers/isbnCurrently added support for only
en-USregions, i.e. 0 & 1 Registration Groups. We can expand this data to support other regions/countries if required in future.Let me know your thoughts, and any fixes if necessary, coz this will be my first Golang PR 😅 🎉 🙌🏽