Implement RSA signature support for WebAssembly. #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `GFp_bn_mul_add_word` with a clearer, simpler implementation. The new `GFp_limbs_mul_add_limb` avoid explicit branches at the C code level, unlike the code it replaces. (Obviously, even with the new "branchless" code the compiler might be able to synthesize branches.)
…enabled. Run the RSA and signature tests in WebAssembly. Implement Elem*Elem multiplication for platforms for which we have no assembly language implementation of it. Refactor the code to accomodate this. `elem_reduced` was infallible previously as it always ensured the prerequisites for the reduction were met. Make this clear in the return type, as a side-effect of the refactoring needed for implementing the multiplication. This implementation is far from efficient. More work needs to be done to make it faster.
This was referenced May 29, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.