AES: Replace "aliasing pointer" pattern with MaybeUninit pattern.
#977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansmith
force-pushed
the
b/use-MaybeUninit-instead-of-aliasing-ptr-in-AES
branch
from
f1bd71a
to
c8a9313
Compare
The code was using the "aliasing pointer" pattern to avoid needing to deal with `core::mem::uninitialized()`. Now we can use `core::mem::MaybeUninit` instead of either.
briansmith
force-pushed
the
b/use-MaybeUninit-instead-of-aliasing-ptr-in-AES
branch
from
c8a9313
to
8e33f10
Compare
|
This raised the minimum Rust version to 1.36. |
Actually, we were using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was using the "aliasing pointer" pattern to avoid needing to
deal with
core::mem::uninitialized(). Now we can usecore::mem::MaybeUninitinstead of either.