Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add support for {mipsel,riscv64gc}-unknown-linux-gnu #1556

Closed
wants to merge 3 commits into from

Conversation

briansmith
Copy link
Owner

No description provided.

LinusU and others added 3 commits November 9, 2022 15:53
Take MIPSEL out of the GitHub Actions configuration because it fails to
link, and because it makes the build matrix too large.
@briansmith
Copy link
Owner Author

This is based on @LinusU's PR #1120.

These two things succeed:

mk/cargo.sh test --target=riscv64gc-unknown-linux-gnu --test=aead_tests
mk/cargo.sh test --target=mipsel-unknown-linux-gnu --test=aead_tests

But, tests that require bn_mul_mont fail because we don't have a fallback; that is what PR #1455 is about.

Also, code coverage measurement doesn't work because the compiler wasn't built with the profiler runtime support for either target:

$ RING_COVERAGE=1 mk/cargo.sh test --target=riscv64gc-unknown-linux-gnu --test=aead_tests
error[E0463]: can't find crate for `profiler_builtins`
  |
  = note: the compiler may have been built without the profiler runtime
$ RING_COVERAGE=1 mk/cargo.sh test --target=mipsel-unknown-linux-gnu --test=aead_tests
error[E0463]: can't find crate for `profiler_builtins`
  |
  = note: the compiler may have been built without the profiler runtime

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #1556 (22fae8e) into main (3915942) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1556      +/-   ##
==========================================
+ Coverage   92.24%   92.26%   +0.01%     
==========================================
  Files         127      127              
  Lines       18850    18850              
  Branches      196      196              
==========================================
+ Hits        17389    17392       +3     
+ Misses       1424     1422       -2     
+ Partials       37       36       -1     
Impacted Files Coverage Δ
crypto/poly1305/poly1305.c 97.20% <0.00%> (+0.46%) ⬆️
src/aead/less_safe_key.rs 96.89% <0.00%> (+0.77%) ⬆️
src/io/der_writer.rs 100.00% <0.00%> (+2.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@briansmith
Copy link
Owner Author

Closing this in favor of #1558.

@briansmith briansmith closed this Nov 11, 2022
@briansmith briansmith deleted the b/mipsel-riscv64gc branch November 11, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants