Added musl targets #1067
Merged
Added musl targets #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansmith
reviewed
Oct 27, 2020
mk/travis.sh
Outdated
| @@ -73,6 +73,12 @@ if [[ ! "$TARGET_X" =~ "x86_64-" ]]; then | |||
| fi | |||
| fi | |||
|
|
|||
| # This stanza is separate from the above because MUSL requires a target install, | |||
| # but does *not* require special linking / multilib. | |||
There was a problem hiding this comment.
Let's remove this comment and...
mk/travis.sh
Outdated
| @@ -73,6 +73,12 @@ if [[ ! "$TARGET_X" =~ "x86_64-" ]]; then | |||
| fi | |||
| fi | |||
|
|
|||
| # This stanza is separate from the above because MUSL requires a target install, | |||
| # but does *not* require special linking / multilib. | |||
| if [[ "$TARGET_X" =~ .*"-unknown-linux-musl" ]]; then | |||
There was a problem hiding this comment.
Let's move the rustup target add from up above to here. We can change the condition to [ "$TARGET_X" =~ .*"-unknown-linux-musl" || ! "$TARGET_X" =~ "x86_64-" ]]` or whatever Bashism.
That way, we have only one place where we do rustup target add. This will be important for other refactoring I am doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off of #935, I added musl targets for i686 and x86_64 using clang as the compiler. Addresses #713