Skip to content

Commit

Permalink
C++ headers should be more aggressively wrapped in extern "C++".
Browse files Browse the repository at this point in the history
This is kind of a mess. Some projects will wrap our public headers in
extern "C", so we use extern "C++" around our C++ APIs. However this
needs to be done when including C++ standard library headers too since
they don't always, themselves, guard against being wrapped in extern
"C".

Change-Id: Ib7dd4a6f69ca81dd525ecaa1418b3b7ba85b6579
Reviewed-on: https://boringssl-review.googlesource.com/18504
Reviewed-by: Adam Langley <agl@google.com>
  • Loading branch information
davidben authored and agl committed Jul 27, 2017
1 parent ec78383 commit af2b1e8
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions include/openssl/span.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,11 @@

#if !defined(BORINGSSL_NO_CXX)

extern "C++" {

#include <algorithm>
#include <type_traits>

#include "../crypto/internal.h"

extern "C++" {

namespace bssl {

template <typename T>
Expand Down

0 comments on commit af2b1e8

Please sign in to comment.