Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize setUnitNoOverflow() #3071

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Optimize setUnitNoOverflow() #3071

merged 1 commit into from
Oct 7, 2024

Conversation

takaram
Copy link
Contributor

@takaram takaram commented Oct 3, 2024 •
edited
Loading

This PR reduces avoidMutation() calls.

@kylekatarnls
Copy link
Collaborator

Sounds good 👍 I'm doing few more tests to check we don't have any mutation side effect for neither Carbon nor CarbonImmutable

@kylekatarnls kylekatarnls self-requested a review October 4, 2024 14:40
@kylekatarnls kylekatarnls added this to the 3.8.1 milestone Oct 4, 2024
@kylekatarnls kylekatarnls merged commit cda6063 into briannesbitt:master Oct 7, 2024
26 checks passed
@takaram takaram deleted the reduce-clone branch October 7, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylekatarnls kylekatarnls kylekatarnls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@takaram @kylekatarnls