Simplify PHPStan extension #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can bring back tests/PHPStan/MacroTest.php in some form if you'd want. |
|
I'm now waiting for your feedback before finalizing this PR. |
kylekatarnls
reviewed
Aug 9, 2024
kylekatarnls
reviewed
Aug 9, 2024
kylekatarnls
reviewed
Aug 9, 2024
kylekatarnls
approved these changes
Aug 9, 2024
ondrejmirtes
force-pushed
the
simplify-phpstan
branch
from
6da002d to
8ac1a7f
Compare
Co-authored-by: Kyle <kylekatarnls@users.noreply.github.com>
Co-authored-by: Kyle <kylekatarnls@users.noreply.github.com>
Co-authored-by: Kyle <kylekatarnls@users.noreply.github.com>
ondrejmirtes
force-pushed
the
simplify-phpstan
branch
from
8ac1a7f to
f52b30d
Compare
ondrejmirtes
force-pushed
the
simplify-phpstan
branch
from
f52b30d to
1569553
Compare
|
And we're green now! 👍 Please squash the commits on merge, thank you. |
kylekatarnls
approved these changes
Aug 13, 2024
|
Thank you 🙏 💟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice, right? :) The main motivation for me to contribute this is for Carbon to stop using non-public facing PHPStan classes like BuiltinMethodReflection (which will be removed in PHPStan 2.0).
Thanks to ClosureTypeFactory, which allows us to create useful PHPStan Reflection objects out of Closure objects, this greatly simplified the PHPStan extension related to macros.
ClosureTypeFactory has been contributed to PHPStan by Can Vural, to support similar macros analysis in Larastan (Laravel), more than 2 years ago.
I hope you like this.