Skip to content

Do not run RuboCop in Container CI #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mishina2228
Copy link
Contributor

@mishina2228 mishina2228 commented Apr 27, 2022

This PR stops running RuboCop in Container CI.
It's intended to suppress errors in fedora fedora:rawhide workflow.
https://github.com/brianmario/mysql2/runs/6182290369?check_suite_focus=true

Running RuboCop...
Inspecting 36 files
...............An error occurred while Lint/BlockAlignment cop was inspecting /build/lib/mysql2/console.rb:3:20.
To see the complete backtrace run rubocop -d.
..................An error occurred while Lint/BlockAlignment cop was inspecting /build/tasks/generate.rake:1:0.
To see the complete backtrace run rubocop -d.
...

36 files inspected, no offenses detected

2 errors occurred:
An error occurred while Lint/BlockAlignment cop was inspecting /build/lib/mysql2/console.rb:3:20.
An error occurred while Lint/BlockAlignment cop was inspecting /build/tasks/generate.rake:1:0.
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
Mention the following information in the issue report:
0.50.0 (using Parser 2.7.2.0, running on ruby 3.1.2 x86_64-linux)
RuboCop failed!

Since there is already a workflow for RuboCop,
there is no need to run it in Container CI as well.

This is an alternative to #1256.
Once this PR is merged, #1256 can be closed.

@junaruga
Copy link
Contributor

Good point!

@mishina2228 mishina2228 force-pushed the do-not-run-rubocop-in-container-ci branch from 9c755df to bec68fc Compare May 30, 2022 09:39
@mishina2228
Copy link
Contributor Author

The errors won't be raised once #1268 is merged,
but excluding the running of RuboCop helps to reduce the time spent on CI.

@sodabrew
Copy link
Collaborator

sodabrew commented Jun 3, 2022

Great suggestion!

@sodabrew sodabrew merged commit 80e0001 into brianmario:master Jun 3, 2022
@mishina2228 mishina2228 deleted the do-not-run-rubocop-in-container-ci branch June 3, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants