This repository was archived by the owner on Sep 27, 2022. It is now read-only.
Split Tabs examples into 2 and updated organization inside them #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjmoore
reviewed
Nov 11, 2016
Owner
brianjmoore
left a comment
brianjmoore
left a comment
There was a problem hiding this comment.
Like it overall! Does this need a clang-format pass? Looks like Xcode mangled the indentation on paste
Collaborator
Author
|
Ugh. Yes. I'm the worst at that. |
Collaborator
Author
|
Ready for review |
brianjmoore
suggested changes
Nov 11, 2016
Owner
brianjmoore
left a comment
brianjmoore
left a comment
There was a problem hiding this comment.
It looks like the formatting pass missed some of the files? Still seeing a few missing indents
|
|
||
| // Long tab bar with lots of items of varying length. Also demonstrates configurable accent color. | ||
| self.tabBar = | ||
| [[MDCTabBar alloc] initWithFrame:CGRectMake(0, 0, CGRectGetWidth(bounds) - 20.0f, 0)]; |
Owner
There was a problem hiding this comment.
did clang-format miss this one? (and a few below)
Collaborator
Author
There was a problem hiding this comment.
No. User error. I spent so long figuring out how to manually use clang-format that I missed all other files.
Collaborator
Author
|
Ready for retest. |
brianjmoore
approved these changes
Nov 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "content" is unchanged.