Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix checkstyle for measurements package #916

Merged
merged 1 commit into from
Feb 3, 2017
Merged

[core] Fix checkstyle for measurements package #916

merged 1 commit into from
Feb 3, 2017

Conversation

risdenk
Copy link
Collaborator

@risdenk risdenk commented Feb 2, 2017

Relates to #895

@risdenk risdenk added this to the 0.13.0 milestone Feb 2, 2017
@risdenk risdenk self-assigned this Feb 2, 2017
@risdenk risdenk requested review from busbey and manolama February 2, 2017 16:55
@risdenk
Copy link
Collaborator Author

risdenk commented Feb 2, 2017

Tested with mvn -pl core -am validate | grep "ycsb/measurements"

@risdenk
Copy link
Collaborator Author

risdenk commented Feb 2, 2017

@manolama - if you could take a peek at this that would be very much appreciated. I found that adding w=1 as a url parameter hides the whitespace only changes.

@risdenk risdenk mentioned this pull request Feb 2, 2017
Merged
@risdenk
Copy link
Collaborator Author

risdenk commented Feb 2, 2017

Required by #920

busbey
busbey requested changes Feb 3, 2017
View reviewed changes
Copy link
Collaborator

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we all the members that went from package-private to protected be changed instead to private?

@risdenk
Copy link
Collaborator Author

risdenk commented Feb 3, 2017

I'll check if they can.

@risdenk risdenk force-pushed the checkstyle-measurements branch from 2c2d53f to 7676fe4 Compare February 3, 2017 15:29
@risdenk
Copy link
Collaborator Author

risdenk commented Feb 3, 2017

@busbey addressed the private comment.

busbey
busbey approved these changes Feb 3, 2017
View reviewed changes
Copy link
Collaborator

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , presuming travis comes back clean.

@risdenk risdenk merged commit bfafcf1 into brianfrankcooper:master Feb 3, 2017
@risdenk risdenk deleted the checkstyle-measurements branch February 3, 2017 15:45
@risdenk
Copy link
Collaborator Author

risdenk commented Feb 3, 2017

Thanks @busbey!

tzm41 pushed a commit to tzm41/YCSB that referenced this pull request May 7, 2017
@risdenk @tzm41
[core] Fix checkstyle for measurements package (brianfrankcooper#916)
53a9215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busbey busbey busbey approved these changes

@manolama manolama Awaiting requested review from manolama

Assignees

@risdenk risdenk

Labels
improvement
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@risdenk @busbey