[hbase098] Fix checkstyle for HBase 0.98.x binding #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risdenk
force-pushed
the
checkstyle-hbase098
branch
from
1604574 to
21c1858
Compare
|
I'll rebase this in a few minutes and push the changes. This is the only remaining binding that doesn't enforce checkstyle! |
risdenk
force-pushed
the
checkstyle-hbase098
branch
from
21c1858 to
750c885
Compare
risdenk
force-pushed
the
checkstyle-hbase098
branch
from
750c885 to
18d8b97
Compare
|
@busbey if you have any spare cycles to review this PR that would be greatly appreciated. It is the last of the checkstyle changes. |
|
I've been using https://github.com/brianfrankcooper/YCSB/pull/902/files?w=1 to check it to ignore the whitespace only changes. |
busbey
requested changes
Feb 3, 2017
| for (Thread t : allthreads) { | ||
| try { | ||
| t.join(); | ||
| } catch (InterruptedException ignored) { |
There was a problem hiding this comment.
This is incorrect behavior. At a minimum the interrupted status for the current thread should be set.
It's a preexisting problem, not something from this fix, so I'd be fine with leaving it so long as there's an issue filed to fix it.
busbey
approved these changes
Feb 3, 2017
|
Thanks @busbey! |
tzm41
pushed a commit
to tzm41/YCSB
that referenced
this pull request
May 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #267 and supersedes #484