Skip to content

install: -m MODE validation #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

install: -m MODE validation #980

merged 1 commit into from
Mar 5, 2025

Conversation

@mknos
Copy link
Contributor

@mknos mknos commented Mar 5, 2025

  • Passing an empty string as a mode was being accepted and interpreted as -m0
  • Empty string is not a valid mode specifier so catch it early
  • I found this when testing against GNU and OpenBSD versions

@mknos
install: -m MODE validation
e5979a5 
* Passing an empty string as a mode was being accepted and interpreted as -m0
* Empty string is not a valid mode specifier so catch it early
* I found this when testing against GNU and OpenBSD versions
@mknos mknos temporarily deployed to housekeeping March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos had a problem deploying to automated_testing March 5, 2025 02:23 — with GitHub Actions Failure
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos had a problem deploying to automated_testing March 5, 2025 02:23 — with GitHub Actions Error
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 5, 2025 02:23 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: install The install program Status: needs verification issue needs to be verified Type: bug an existing feature does not work labels Mar 5, 2025
@github-actions github-actions bot requested a review from briandfoy March 5, 2025 02:23
@coveralls
Copy link

coveralls commented Mar 5, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13667108540

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 70.088%
Totals Coverage Status
Change from base Build 13656102414: -0.9%
Covered Lines: 396
Relevant Lines: 565
💛 - Coveralls

@briandfoy
Copy link
Owner

briandfoy commented Mar 5, 2025

changes: catch empty argument to -m

@briandfoy briandfoy merged commit db94949 into briandfoy:master Mar 5, 2025
21 of 24 checks passed
@briandfoy briandfoy self-assigned this Mar 5, 2025
@github-actions github-actions bot added Status: accepted The fix is accepted and removed Status: needs verification issue needs to be verified Priority: low get to this whenever labels Mar 5, 2025
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels

Program: install The install program Status: released there is a new release with this fix Type: bug an existing feature does not work Type: enhancement improve a feature that already exists

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mknos @coveralls @briandfoy