LPS-114004 Replace layout classes with new clay taglibs in account-admin-web #89245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
liferay-continuous-integration
deleted the
ci-forward-LPS-114004_layouts_account-admin-web-pr-1076-sender-eduardoallegrini-ts-1590531470309
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: drewbrokke#1076 (Took 1
ci:forwardattempt in 3 minutes)@eduardoallegrini
@drewbrokke
Original pull request comment:
Hey @drewbrokke , this is a simple code replacement that uses the new Clay Taglibs for old code like
<div class="sheet sheet-lg">><clay:sheet>.Please, could you check if the module is still showing correctly or reply with instructions to see it?
I can't provide an official documentation right now, we have discussed the whole thing in this pr (liferay/clay#3204) but I'm creating a quick list of the usages found so far in this google sheet (https://docs.google.com/spreadsheets/d/1mXjvokQRqSMuQtpghUAFLb2Igd21zgJvc8whUmV_-EU/edit?usp=sharing)
/cc @jbalsas @marcoscv-work
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: a0bfd3552193bb33687ef3677fe4879447e04d6a
Sender Branch:
Branch Name: LPS-114004_layouts_account-admin-web
1 out of 1jobs PASSEDBranch GIT ID: 15d34fe77dc6f935e615e1f220a1ca4e821807b2
1 Successful Jobs:
For more details click here.
✔️ ci:test:stable - 19 out of 19 jobs passed
✔️ ci:test:relevant - 42 out of 42 jobs passed in 1 hour 12 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 884cd741c11f60df048c695bd2567d3c69bd411e
Copied in Private Modules Branch:
Branch Name: master-private
Branch GIT ID: 6845814bf7a2b1b38f7c5a057c77bb287029faf4
ci:test:stable - 19 out of 19 jobs PASSED
19 Successful Jobs:
ci:test:relevant - 42 out of 42 jobs PASSED
42 Successful Jobs:
For more details click here.