LPS-113692 New Layout JSP Tags #88881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luid-container for better semantics and defaults
Starting at LPS-91526, the tag class is added to the request for performance and backwards compatibility reasons, so we don't need to set the independent attributes in the request and can use BeanPropertiesUtils to inspect the necessary values in a safer way.
…ew default container
…gic with upcoming content containers
…reuse className generation logic
… a different HTML tag than simple divs
…y tags This is done to simplify adding custom attributes to the layout containers such as aria or any supported html attribute. Attributes are set without any further processing. This adds out of the box support for the `id` attribute. This is the reason to remove it from the tld. Since we're not processing it in any way, it's best to keep it inline with other html attributes. Being supported through the new dynamic attributes support also means that this should not necessarily introduce a breaking change.
|
Closing pull request because all |
|
ci:reopen |
|
Merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual forward from: https://github.com/wincent/liferay-portal/pull/270
One "unique" failure looks spurious/transitory.
Original message follows.
Fairly dense PR related to Layout JSP Tags. Kind of a follow up of #88326 (which in itself was https://github.com/wincent/liferay-portal/pull/245)
This PR pushes forward the tags adding some of the feedback gathered in Clay's own feat(@clayui/layout): create low-level layout utilities.
So, without further ado... the PR:
BaseContainerTagfrom which to extend further Layout components. This could be namedBaseLayoutTag. Since it's internal, we can change it later if that makes more sense.processClassNameso different tags can define which CSS classes are passedclassNameis always supported and properly concatenated for all layout tagscontainerElementso it's possible to output something liketd class="autofit-row"instead of always forcing adivDynamicAttributesso tags accept any HTML attribute even if not defined in the tld:<clay:container foo="fasd" aria-rol="button" aria-title="bar">...</clay:container>clay:containermore generic and creates a specificclay:container-fluidtag which is the one we specifically use in DXPclay:containerwith the newclay:container-fluidclay:content-col,clay:content-rowandclay:content-sectionfor theautofluiduse caseclay:sheet,clay:sheet-footer,clay:sheet-headerandclay:sheet-sectionfor thesectioncaseblogs/blogs-webto see examples ofclay:content*tagsdepot/depot-webto see examples ofclay:sheet*tags@adolfopa, I think this is a fairly low risk PR, but would you mind having someone on your team take a look?
/cc @marcoscv-work, @bryceosterhaus, @eduardoallegrini