Repository navigation
pg-native: read all the values of a result in one call - #3814
Open
nigrosimone wants to merge 1 commit into
Open
nigrosimone wants to merge 1 commit into
nigrosimone wants to merge 1 commit into
Conversation
nigrosimone
marked this pull request as ready for review
October 11, 2026 08:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pg-native builds a result with one native call per value (
getvalue, plusgetisnullwhen the value is''). On large results this is the main cost, and it is why pg-native is slower than pg on 100 and 500 rows in the postgres-benchmarks, more on some CPUs than others.When libpq has
getvalues(brianc/node-libpq#144) all the values are read in one call. With an older libpq nothing changes. In a microbenchmark building the result takes 52-60% less time for 100 and 500 rows, about 10% less for 1 row.Test added in
test/build-result.jswith a fake libpq result, so it runs without the new libpq: it checks both paths, and fails without the fix.