perf: Copy less when serializing Bind messages - #3740
Merged
Conversation
instead of creating a separate `paramWriter`.
…er` shrinks values It would have created an incomplete message anyway, but I figured this was vaguely plausible, bad enough, and easy enough to fix. No test though, because the test is annoying to write. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
brianc
approved these changes
Aug 12, 2026
| const writeValues = function (values: any[], valueMapper?: ValueMapper): void { | ||
| for (let i = 0; i < values.length; i++) { | ||
| const writeValues = function (values: any[], valueMapper: ValueMapper | undefined, formatsOffset: number): void { | ||
| const len = values.length |
Owner
There was a problem hiding this comment.
surprising this is still a perf improvement in 2026!
Collaborator
Author
There was a problem hiding this comment.
I’m not sure whether there’s a performance effect, but it was mainly for #3740 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes about 15–30% less time on some parameter values in my measurements. Performance here could still be improved by a lot, but many other improvements also need interface changes, so I separated out this patch that was fully backwards-compatible.