fix: reject portal based queries in pipeline mode instead of TypeError - #3737
Merged
brianc merged 1 commit intoAug 12, 2026
Merged
Conversation
nigrosimone
force-pushed
the
reject-portal-queries-in-pipeline
branch
from
August 9, 2026 11:58
8316f6f to
7e175a8
Compare
nigrosimone
marked this pull request as ready for review
August 9, 2026 12:03
brianc
approved these changes
Aug 12, 2026
brianc
left a comment
Owner
There was a problem hiding this comment.
this is cool - yeah its kinda unfortunate pipeline mode prevents some other stuff but it also makes sense. pipeline is "make the fast & straight forward things faster" and cursors or streams are "make the fiddly pieces easier for node to deal with"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A portal stays open across more round trips. In pipeline mode the queries behind it are written without waiting, so the server answer them out of that portal: the rows go to the wrong query, the next read fails with
portal "..." does not exist, and with pg-cursor the process dies with an uncaughtTypeError: Cannot read properties of null (reading 'push')insidehandleDataRow.Two cases, both reproducible every time on a client with
pipeline: true: