fix: fail pipelined queries when the connection dies instead of hanging - #3736
Merged
Merged
Conversation
nigrosimone
marked this pull request as ready for review
August 9, 2026 10:51
nigrosimone
changed the title
brianc
approved these changes
Aug 12, 2026
brianc
left a comment
brianc
left a comment
Owner
There was a problem hiding this comment.
a bit confusing on first glance but the PR description and tests make it readable. :) thanks a ton!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a pipelined batch is in flight and the connection goes away, the batch never call back, so every query queued behind it wait forever.
There is also a related bug in node-libpq, brianc/node-libpq#137 The fixes here are independent from that one, but both are needed to survive a lost connection.