Fix: Add validation for invalid date query parameter values

[18rameez]

PR for Issue #3318

Issue Description:
Currently, new Date(undefined) (an invalid date) is serialized as "0NaN-NaN-NaNTNaN:NaN:NaN.NaN+NaN:NaN". It should fail early with a JS error instead of being passed to the database.

[charmander]

The query callback can only be called once (and if it weren’t, we wouldn’t want to silently ignore that):

Suggested change

	var calledDone = false
	client.query(new pg.Query({ text: 'SELECT $1::timestamp', values: [new Date(undefined)] }), function (err, res) {
	if (!calledDone) {
	calledDone = true
	assert.equal(err.message, 'Query parameter value cannot be an invalid date.')
	client.end(done)
	}
	})
	client.query(new pg.Query({ text: 'SELECT $1::timestamp', values: [new Date(undefined)] }), function (err, res) {
	assert.equal(err.message, 'Query parameter value cannot be an invalid date.')
	client.end(done)
	})

[18rameez]

It will cause this error, as the connection also gets terminated, and the callback will be executed again.

Message: 'Connection terminated' == 'Query parameter value cannot be an invalid date.'
AssertionError [ERR_ASSERTION]: 'Connection terminated' == 'Query parameter value cannot be an invalid date.

[charmander]

That’s a serious bug, then.

[ikonst]

What happens in the 'native' case?

[brianc]

hmmm...I'm not sure we should be in the business of validating the date passed to the library isn't invalid. The backend already does this w/ an informative error saying the date is bad. If this resulted in insert garbage or doing something unexpected I'd be more concerned, but this already results in an error.

[ikonst]

@brianc The way it fails is with this cryptic date string. If you're intent on sending it, you can serialise it as "InvalidDate" or something like that, so that the cause would be clearer.