Fail gracefully when connecting to other database

[romain-gilliotte]

Fixes #2627

I'm currently working at Forest Admin.
We're a French company building a SaaS that generates admin panels.

During onboarding, we connect to our customer's databases to introspect the structure.
However, customers don't always know which database vendor they are using, and click on the wrong one during onboarding.

This causes pg-protocol to throw an unhandled exception, and our backend workers to go down.

I tried to follow the coding style and test this.
Don't hesitate to come back to me if anything is not at it should be!

Note that I never managed to run all the tests locally... so I'm likely to break others.
I'm creating the PR so that the CI runs, and that I can check if everything is OK

[brianc]

Hey @romain-gilliotte thanks for doing this! This has actually be a long time thorn in the side of folks, and any UnahandledRejection is no beuno. The tests failed because the native driver bindings actually already properly throw and don't crash with an unhandled rejection, but the error message is different. I'm going go ahead and push to your fork and fix the tests so we're good to merge this, and then merge it!

[romain-gilliotte]

Thank you so much for looking into this!

[Scra3]

Hello @brianc and @romain-gilliotte.
@brianc apparently there's still a test that's failing, do you need help or do you need a little time to fix the test? 🙏

[charmander]

(Re-ran the test with the Cloudflare-worker-related segfault, it passed.)

[Scra3]

Hello,
Can we merge 🙏 ?
Thank you very much for the work and time spent on the bug.

[slimee]

It seems this PR is ready to merge, can we go please?
It would helps a lot 🙏🏽

[slimee]

Thanks Le ven. 15 sept. 2023, 23:23, Brian C ***@***.***> a écrit :

…

Merged #3026 <#3026> into master. — Reply to this email directly, view it on GitHub <#3026 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYNLYQLVLMW22U3DFUIPB3X2TBMJANCNFSM6AAAAAAZ67P5DE> . You are receiving this because you commented.Message ID: ***@***.***>

[Scra3]

ty

[Scra3]

Hello,
Is it possible to release it on npm 🙏 ?