Perf: Optimize Network.run loop via unswitching and int tracking #1752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the run loop to avoid invariant checks for single-clock sims. Also swapped slow numpy scalar lookups for local int tracking. Benchmarks show ~5% speedup while keeping stop() working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the main simulation loop in
Network.runhad some overhead from repeated checks that don't change during a run (likesingle_clockanddevice).I refactored it to split the "fast path" (single clock) from the multi-clock logic.
Also,
timestep[0]is a numpy scalar, which is surprisingly slow to access in a hot loop. I replaced it with a local integer counter just for the loop condition.Benchmarks (1M steps, pure Python):
Verified that
stop()andNetworkOperationstill trigger correctly with the new logic.