Synchronize idleTimeout manipulation methods

brettwooldridge · Aug 4, 2021 · 7a0a156 · 7a0a156
1 parent bab9f64
commit 7a0a156
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/com/zaxxer/hikari/HikariConfig.java b/src/main/java/com/zaxxer/hikari/HikariConfig.java
@@ -194,14 +194,14 @@ else if (connectionTimeoutMs < SOFT_TIMEOUT_FLOOR) {
 
    /** {@inheritDoc} */
    @Override
-   public long getIdleTimeout()
+   public synchronized long getIdleTimeout()
    {
       return idleTimeout;
    }
 
    /** {@inheritDoc} */
    @Override
-   public void setIdleTimeout(long idleTimeoutMs)
+   public synchronized void setIdleTimeout(long idleTimeoutMs)
    {
       if (idleTimeoutMs < 0) {
          throw new IllegalArgumentException("idleTimeout cannot be negative");

diff --git a/src/test/java/com/zaxxer/hikari/db/BasicPoolTest.java b/src/test/java/com/zaxxer/hikari/db/BasicPoolTest.java
@@ -77,14 +77,14 @@ public void testIdleTimeout() throws InterruptedException, SQLException
       System.setProperty("com.zaxxer.hikari.housekeeping.periodMs", "1000");
 
       try (HikariDataSource ds = new HikariDataSource(config)) {
+         getUnsealedConfig(ds).setIdleTimeout(3000);
+
          System.clearProperty("com.zaxxer.hikari.housekeeping.periodMs");
 
          SECONDS.sleep(1);
 
          HikariPool pool = getPool(ds);
 
-         getUnsealedConfig(ds).setIdleTimeout(3000);
-
          assertEquals("Total connections not as expected", 5, pool.getTotalConnections());
          assertEquals("Idle connections not as expected", 5, pool.getIdleConnections());