Fix a naming bug (#37)

brettcannon · May 16, 2020 · a4f131e · a4f131e
1 parent 7ddc560
commit a4f131e
Show file tree

Hide file tree

Showing 10 changed files with 158 additions and 99 deletions.
diff --git a/.flake8 b/.flake8
@@ -0,0 +1,3 @@
+[flake8]
+ignore = C,E,W
+exclude = .venv
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -20,8 +20,10 @@ jobs:
 
     - run: poetry install
 
-    - run: pytest tests
+    - run: flake8
 
     - run: mypy --ignore-missing-imports release_often/
 
+    - run: pytest tests
+
     - run: black --check .
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -23,10 +23,12 @@ jobs:
 
     - run: poetry install
 
-    - run: pytest tests
+    - run: flake8
 
     - run: mypy --ignore-missing-imports release_often/
 
+    - run: pytest tests
+
     - run: black --check .
 
 

diff --git a/CHANGES.md b/CHANGES.md
@@ -1,5 +1,7 @@
 # Changelog
 
+Work from a push event instead of a pull request event.
+
 ## 0.6.1
 [PR #31](https://github.com/brettcannon/release-often/pull/31): Make reST changelog entry use anonymous links (thanks [brettcannon](https://github.com/brettcannon))
 

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -21,6 +21,7 @@ black = "^19.10b0"
 mypy = "^0.770"
 pytest = "^5.4.2"
 pytest-asyncio = "^0.12.0"
+flake8 = "^3.8.1"
 
 [build-system]
 requires = ["poetry>=0.12"]

diff --git a/release_often/__main__.py b/release_often/__main__.py
@@ -74,7 +74,7 @@ def update_changelog(path, new_version, pr_event):
         current_changelog, path.suffix, new_version, pr_event
     )
     path.write_text(new_changelog, encoding="utf-8")
-    return event["pull_request"]["title"]
+    return pr_event["title"]
 
 
 def build():

diff --git a/tests/test_flit.py b/tests/test_flit.py
@@ -1,5 +1,3 @@
-import pathlib
-
 import pytest
 
 from release_often import flit

diff --git a/tests/test_poetry.py b/tests/test_poetry.py
@@ -1,5 +1,3 @@
-import pathlib
-
 import pytest
 import tomlkit
 

diff --git a/tests/test_release.py b/tests/test_release.py
@@ -3,7 +3,6 @@
 import trio
 
 from release_often import release
-from . import data
 
 
 class MockGitHubAPI: