Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle long file names that get truncated by github #55

Merged
2 commits merged into from
Jan 31, 2018

Conversation

bjohnson-va
Copy link
Contributor

@bjohnson-va bjohnson-va commented Jan 29, 2018

When file paths are long, github truncates the text above the diff (the
innerHTML) but leave the title in-tact.

This commit changes Pretty PRs to consider the title instead of the
innerHTML when identifying common paths.

@byates-va @Yatser

Before

screen shot 2018-01-29 at 4 20 08 pm

After

screen shot 2018-01-29 at 4 19 44 pm

image

When file paths are long, github truncates the text above the gif (the
innerHTML) but leave the title in-tact.

This commit changes Pretty PRs to consider the title instead of the
innerHTML when identifying common paths.
@ghost ghost merged commit bfc19da into brentyates:master Jan 31, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant