-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX Fixes for Enterprise #49
Conversation
@rianrainey you aren't a member of the project so you can't contribute directly to my branch unfortunately. Forking and making your own is the right way to go 👍 so thanks for that. |
@gholtslander-va Good. Want me to try to get the bottom collapse working before merging this? |
Sounds good, it's working in the non-Enterprise version so it'd be nice to get it working in the Enterprise! |
Let me know when we want to release this! Thanks for the contribution @rianrainey |
I'd rather have these changes release w/o the bottom bar for how long this is taking. Currently, this plugin isn't working on enterprise at all. |
* Parse GH Enterprise url only once * Use modern APIs
Okay, the bottom collapse is fixed now for Enterprise. This should be ready to be merged. Let me know if you want any modification or changes. Thanks! |
Releasing this right now, expect the changes to roll out in an hour or whatever it takes. |
@gholtslander-va I couldn't seem to have permission to add my commit to your branch so I had to fork and make the PR this way. Feel free to add my commits to your PR or use this PR. My commit got the toggling to work correctly. However, the bottom toggling still doesn't work. Need to look at that.
Fixes #43