-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acts_as_list_no_update #244
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
25396ea
acts_as_list_no_update
randoum 41e1700
Fix postgressql test failures
randoum a085a73
Fix postgressql test failures
randoum e9f0cc4
Fix postgressql test failures + merge last commit
randoum fcc5334
Merge branch 'master' into master
randoum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
module ActiveRecord | ||
module Acts | ||
module List | ||
module NoUpdate | ||
extend ActiveSupport::Concern | ||
|
||
module ClassMethods | ||
# Lets you selectively disable all act_as_list database updates | ||
# for the duration of a block. | ||
# | ||
# ==== Examples | ||
# ActiveRecord::Acts::List.acts_as_list_no_update do | ||
# TodoList.... | ||
# end | ||
# | ||
# TodoList.acts_as_list_no_update do | ||
# TodoList.... | ||
# end | ||
# | ||
def acts_as_list_no_update(&block) | ||
NoUpdate.apply_to(self, &block) | ||
end | ||
end | ||
|
||
class << self | ||
def apply_to(klass) | ||
klasses.push(klass) | ||
yield | ||
ensure | ||
klasses.pop | ||
end | ||
|
||
def applied_to?(klass) | ||
klasses.any? { |k| k >= klass } | ||
end | ||
|
||
private | ||
|
||
def klasses | ||
Thread.current[:act_as_list_no_update] ||= [] | ||
end | ||
end | ||
|
||
def act_as_list_no_update? | ||
NoUpdate.applied_to?(self.class) | ||
end | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use this: http://stackoverflow.com/a/20959470/129798
So instead of changing what's expected, augment the scope conditionally:
ListMixin.where(parent_id: 20).order('pos NULLS FIRST').map(&:pos)