Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement state for zoom and search #198

Merged
merged 13 commits into from
Aug 31, 2021
Merged

Implement state for zoom and search #198

merged 13 commits into from
Aug 31, 2021

Commits on Mar 2, 2020

  1. Implement zoom state 

    Using history.replaceState[1], a zoom state can be accessed by using the
y and x frame attributes. history.pushState was explicitly not used
since it would bring a slew of new issues to resolve (browser back and
forward state).

1. https://developer.mozilla.org/en-US/docs/Web/API/History_API
    @versable
    versable committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    3acba28 View commit details
    Browse the repository at this point in the history

  2. Implement a more robust js GET URI solution

    @versable
    versable committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    68999a1 View commit details
    Browse the repository at this point in the history

  3. Add state for search queries

    @versable
    versable committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    0311b99 View commit details
    Browse the repository at this point in the history

  4. Completely clear the URI component when possible

    @versable
    versable committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    c9e69e5 View commit details
    Browse the repository at this point in the history

  5. Use a more natural order of the x and y GET params

    @versable
    versable committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    8404f5c View commit details
    Browse the repository at this point in the history

  6. Simplify attribute check for zoom state

    @versable
    versable committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    3792bcd View commit details
    Browse the repository at this point in the history

  7. Do not encode the search term twice

    @versable
    versable committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    85a5cae View commit details
    Browse the repository at this point in the history

  8. Encode GET parameters in a more sensible place, add comments

    @versable
    versable committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    fd1f817 View commit details
    Browse the repository at this point in the history

  9. Fix search state for changes introduced in 2278e4c

    @versable
    versable committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    6b6e7a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Collapse event listener for keydown events

    @versable
    versable committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    6b77cef View commit details
    Browse the repository at this point in the history

  2. Simplify JS search function 

    - Do not overwrite the passed term variable in search()
- Passed search parameter overwrites currentSearchTerm
    @versable
    versable committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    2c1291e View commit details
    Browse the repository at this point in the history

  3. Remove useless return statement

    @versable
    versable committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    aea09c5 View commit details
    Browse the repository at this point in the history

  4. Properly reset zoom on zooming on root element

    @versable
    versable committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    23b23ad View commit details
    Browse the repository at this point in the history