Sourcery Starbot ⭐ refactored brendancsmith/splinterbot #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
Jan 7, 2024
| cart = panelBrowser.parse_shopping_cart() | ||
|
|
||
| return cart | ||
| return panelBrowser.parse_shopping_cart() |
Author
There was a problem hiding this comment.
Function EnrollmentChecker.check_shopping_cart refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
|
|
||
| def nav_home(self): | ||
| self.driver.visit('http://' + self.domain) | ||
| self.driver.visit(f'http://{self.domain}') |
Author
There was a problem hiding this comment.
Function MyRedBrowser.nav_home refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-36
to
+37
| if not self.domain in self.driver.url: | ||
| self.driver.visit('http://' + self.domain) | ||
| if self.domain not in self.driver.url: | ||
| self.driver.visit(f'http://{self.domain}') |
Author
There was a problem hiding this comment.
Function WFBrowser.nav_home refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan) - Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| optionValues = [el.value for el in optionEls] | ||
|
|
||
| return optionValues | ||
| return [el.value for el in optionEls] |
Author
There was a problem hiding this comment.
Function WFBrowser.option_values_of_select refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-31
to
+32
| username = raw_input(userLabel + ': ') | ||
| password = getpass(passLabel + ': ') | ||
| username = raw_input(f'{userLabel}: ') | ||
| password = getpass(f'{passLabel}: ') |
Author
There was a problem hiding this comment.
Function LoginManager.ask refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
Comment on lines
+39
to
+45
| try: | ||
| assert len(value) == 2 | ||
| except (TypeError, AssertionError): | ||
| pass | ||
| else: | ||
| try: | ||
| assert len(value) == 2 | ||
| except (TypeError, AssertionError): | ||
| pass | ||
| else: | ||
| login = LoginManager.Login(*value) | ||
| return super(LoginManager, self).__setitem__(key, login) | ||
| login = LoginManager.Login(*value) | ||
| return super(LoginManager, self).__setitem__(key, login) |
Author
There was a problem hiding this comment.
Function LoginManager.__setitem__ refactored with the following changes:
- Remove unnecessary else after guard condition (
remove-unnecessary-else)
| def _extend_driver(driver): | ||
| def find_by_text(self, text): | ||
| return self.find_by_xpath("//*[text()='%s']" % text) | ||
| return self.find_by_xpath(f"//*[text()='{text}']") |
Author
There was a problem hiding this comment.
Function Browser._extend_driver refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring)
| # avoid colons in the email message | ||
| with GmailServer(self.address, self.password) as mailServer: | ||
| print('sending: ' + msg) | ||
| print(f'sending: {msg}') |
Author
There was a problem hiding this comment.
Function Gmail.send_email refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Apply Sweep Rules to your PR?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: