Fixed CI/CD workflow for issue #182 / #232 #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
Owner
|
Awesome work, just need to fix the permissions issue |
Author
|
Sorry, looks like I added a comment into the chmod script - should be okay now! |
eshack94
pushed a commit
to eshack94/devops-exercises
that referenced
this pull request
Oct 21, 2023
…regman-arie#254) * updated the CI/CD workflow so it works * fixing typos * changed the branch name for the CI pull request * fixing PEP8 issues inside binary_search.py * removed venv from flask8 local testing * fixing executable permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scripts/run_ci.shci_workflow.ymlas I feel they are not neededmaster, happy to add/change if you needpip install flake8instead ofapt installcoding/python/binary_search.pyto reflect the flake8 rulesFixes issue: #182
Related: #232 - I noticed this PR is inactive so never used this.
Tested and it works. 😄